@sgiehl opened this Pull Request on December 10th 2017 Member

Currently the truncate twig filter might cut off encoded entities or cut strings to early if encoded entities are within it, this changes should prevent that.

@mattab commented on December 10th 2017 Owner

as it is security related (could introduce xss), before we could merge this we would need unit tests.

@sgiehl commented on December 10th 2017 Member

actually it shouldn't be security related, as it doesn't change the string. But can add some test nevertheless.

@sgiehl commented on December 11th 2017 Member

Added some simple tests...

This Pull Request was closed on December 13th 2017
Powered by GitHub Issue Mirror