@sgiehl opened this Pull Request on November 19th 2017 Member

fixes #5230

@tsteur commented on November 19th 2017 Owner

I reckon making this extensible for plugins will be a different issue right? Could otherwise maybe just post an event with an array like [z => {{ 'CoreHome_ShortcutZenMode'|translate }}] and keep the template a bit more stupid? Some plugins add further shortcuts on some pages (such as session recording)

@mattab commented on November 19th 2017 Owner

Would be good to make the Help popup already extensible if possible.

Otherwise, nice new feature :+1:

@sgiehl commented on November 19th 2017 Member

As such shortcuts will always be added in JavaScript I'll try to move some logic there...

@tsteur commented on November 19th 2017 Owner

👍

@sgiehl commented on November 19th 2017 Member

I've now implemented a new method piwikHelper.registerShortcut, which basically bypasses Mousetrap.bind, but additionally saves the keystroke and description for it, which will then be shown on the help screen...

@mattab commented on November 20th 2017 Owner

LGTM. @tsteur could you maybe check & merge this one?

@sgiehl commented on November 22nd 2017 Member

Rebased branch and resolved conflicts... @tsteur any additional change requests?

This Pull Request was closed on November 30th 2017
Powered by GitHub Issue Mirror