@mattab opened this Issue on November 10th 2017 Owner

For consistency and clarity, let's remove rows that don't have "visits" in the Device Type report. The report currently looks like this:
device type

The rows Camera/Car browser/Feature phone/Smart display should be hidden.

@sgiehl commented on November 10th 2017 Member

This is on purpose. We do similar stuff in the browser plugins report. All plugins will be shown there even if some didn't have a visit.
Imho that makes very much sense if we have a static number of records, as this makes the report consistent - the device types will likely never change - and that way it is possible to show row evolution for an entry even if there were no visits in the current period.

@mattab commented on November 11th 2017 Owner

I'd still hide them, because same reasoning could apply to all reports (show rows that once had a value but don't in the selected period), but if we did it everywhere it would end up cluttering all reports (and in general, is not needed). So for consistency we should hide them all. If a user wants to see all "possible" rows/values, they can select "Year" report and it will show all values they got within the year. Other values are not useful anyway. Making the report consistent number of rows is not needed in these cases (as opposed to other reports in Engagement for example, where it is useful and more clear to show all values)

@mattab commented on November 11th 2017 Owner

Edited issue to also hide rows in the Browser plugin report as you point out

@sgiehl commented on November 12th 2017 Member

The biggest reason I see why displaying all rows makes sense in this cases is that the user directly sees what Piwik is able to detect.

@tsteur commented on November 12th 2017 Owner

👍 to keep existing behaviour

@mattab commented on November 12th 2017 Owner

The biggest reason I see why displaying all rows makes sense in this cases is that the user directly sees what Piwik is able to detect.

To provide the same information we could list all the possible values that can be detected in the report documentation, so that users can click the Help icon to see what possible values can be detected. We do this already in "All Referrers > Referrer Types" and possibly others. IMHO it's not good use of screen to list empty rows just for 1% of the time where users may need this information.

@tsteur commented on November 13th 2017 Owner

Not sure there is too much space wasted? I quite liked the thought of the ability to apply eg row evolution on all the rows etc. but no big opinion on that

Powered by GitHub Issue Mirror