Useful for many use cases for example:
I think tests need to be fixed but otherwise 👍
I noticed the same issue. @sgiehl could you investigate more and see if you can generate test data and how? would be great to merge this one asap
I've now figured out why there weren't any suggest values. But unfortunately there still seems to be a bug in the segment itself. It does not seem to work, as there aren't any matches. Weren't able to get any results in segmented visitor logs. It seems the changes in TableLogActions (https://github.com/piwik/piwik/pull/12236/files#diff-fdad89cc205c1e002ab8f49d1cd3ab76) prevents any results. Not sure yet how to fix it. Guess I need to dig a bit deeper
@mattab my last changes should fix it. the eventurl is stored without protocol, so it needs to be removed from suggested values.
Looks good @sgiehl
There is only one last failing test in CustomDimensions:
1) Piwik\Plugins\CustomDimensions\tests\System\ApiTest::testApi with data set <a href='/24'>#24</a> (array('API.getSegmentsMetadata'), array(1, '2013-01-23 01:23:45', array('year'))) Piwik\Plugins\CustomDimensions\tests\System\ApiTest: Differences with expected in '/home/travis/build/piwik/piwik/plugins/CustomDimensions/tests/System/processed/test___API.getSegmentsMetadata.xml' Failed asserting that two DOM documents are equal. --- Expected +++ Actual @@ @@ <row>outlinkUrl</row> + <row>eventUrl</row> @@ @@ <segment>eventName</segment> + </row> + <row> + <type>dimension</type> + <category>Events</category> + <name>Event URL</name> + <segment>eventUrl</segment> + <acceptedValues>The URL must be URL encoded, for example: http%3A%2F%2Fexample.com%2Fpath%2Fpage%3Fquery</acceptedValues> </row> <row> <type>dimension</type>
Could you maybe merge the PR afterwards once tests green?
That needs to be updated in customdimensions plugin. We can do that after
merge as well.
Ok will merge now :+1: Thanks for the work on this!