@fdellwing opened this Pull Request on October 24th 2017 Contributor

this should fix uneven styling in widgets. could not monitor any unwanted differences, but it is possible.

For more infos including a screenshot of status quo see #12175

@Findus23 commented on October 24th 2017 Member

Hi, you can see the result of the UI tests here: https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24885/

@fdellwing commented on October 24th 2017 Contributor

Ok, I looked throught the differences and all but one minor change is expected. I see no problem to merge this.

https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24885/UIIntegrationTest_dashboard2.png -> Looks good to me.

https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24885/UIIntegrationTest_dashboard3.png -> Minor unintented difference (Visitor Map). Should be no problem.

https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24885/UIIntegrationTest_dashboard4.png -> Looks good to me.

https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24885/Dashboard_reset.png -> Minor unintented difference (Visitor Map). Should be no problem.

https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24885/DashboardManager_create_new.png -> Minor unintented difference (Visitor Map). Should be no problem.

@mattab commented on November 22nd 2017 Owner

Congrats @fdellwing for your first PR :tada:

@fdellwing commented on November 23rd 2017 Contributor

Thanks :+1:

This Pull Request was closed on November 22nd 2017
Powered by GitHub Issue Mirror