@fdellwing opened this Issue on October 12th 2017 Contributor

As you can see on the screenshot, this card (.widget .widgetContent .card) has no padding to the widget border, looking really awfull.

.widget .dataTableVizEvolution has 10px left and right.
.widget .sparkline has 5px margin left

So we have 3 different styles in one widget. Thats not looking clean at all.

piwik

@mattab commented on October 12th 2017 Owner

Thanks for the report @fdellwing
Yes, we need to have the same consistent padding everywhere.
Would be great if you can submit a pull request addressing this change :+1:

@fdellwing commented on October 13th 2017 Contributor

Well, giving the card class padding is not as hard. But I'm pretty sure I should not give the sparkline 10px, I think a container (maybe a card) around the sparklines should be usefull?

@mattab commented on October 19th 2017 Owner

we wouldn't want a visible container around sparklines

@fdellwing commented on October 20th 2017 Contributor

As long as I know, a card has no visible border.

@mattab commented on October 23rd 2017 Owner

@fdellwing I propose you create a Pull request, which will trigger our UI tests and take all screenshots, so we can easily see whether something changed and how :+1:

@mattab commented on November 22nd 2017 Owner

Fixed in #12220

This Issue was closed on November 22nd 2017
Powered by GitHub Issue Mirror