@Findus23 opened this Pull Request on October 7th 2017 Member

There are even more HTTP links inside of piwik.

I'll have to wait for the tests as I am not sure if it breaks anything.

@Findus23 commented on October 8th 2017 Member

Please don't merge it yet. There are some minor fixes required.

(e.g. http://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/24673/UIIntegrationTest_admin_themes.png)

@sgiehl commented on October 8th 2017 Member

@Findus23 some test files need to be updated

@Findus23 commented on October 14th 2017 Member

I hope I have now fixed all tests and the new changes didn't break anything.

The CustomDimentions plugin tests probably need to be changed:

```diff diff --git a/angularjs/manage/list.directive.html b/angularjs/manage/list.directive.html index bbd410c..50f2243 100644 --- a/angularjs/manage/list.directive.html +++ b/angularjs/manage/list.directive.html @@ -2,7 +2,7 @@

{{ 'CustomDimensions_CustomDimensions'|translate }}

-

+

diff --git a/tests/System/expected/test___API.getReportMetadata_day.xml b/tests/System/expected/test___API.getReportMetadata_day.xml index 3a73a10..290d865 100755 --- a/tests/System/expected/test___API.getReportMetadata_day.xml +++ b/tests/System/expected/test___API.getReportMetadata_day.xml @@ -135,7 +135,7 @@ CustomVariablesgetCustomVariablesCustom Variable name - This report contains information about your Custom Variables. Click on a variable name to see the distribution of the values. <br /> For more information about Custom Variables in general, read the <a href="http://piwik.org/docs/custom-variables/" rel="noreferrer" target="_blank">Custom Variables documentation on piwik.org</a> + This report contains information about your Custom Variables. Click on a variable name to see the distribution of the values. <br /> For more information about Custom Variables in general, read the <a href="https://piwik.org/docs/custom-variables/" rel="noreferrer" target="_blank">Custom Variables documentation on piwik.org</a>VisitsUnique visitors @@ -1402,7 +1402,7 @@ ActionsgetSiteSearchKeywordsKeyword - This report lists the Search Keywords that visitors searched for on your internal Search Engine.<br/><br/>Tracking searches that visitors make on your website is a very effective way to learn more about what your audience is looking for, it can help find ideas for new content, new Ecommerce products that potential customers might be searching for, and generally improve the visitors' experience on your website.<br/><br/><a href="http://piwik.org/docs/site-search/" rel="noreferrer" target="_blank">Learn more about Tracking how your visitors use your Search engine.</a> + This report lists the Search Keywords that visitors searched for on your internal Search Engine.<br/><br/>Tracking searches that visitors make on your website is a very effective way to learn more about what your audience is looking for, it can help find ideas for new content, new Ecommerce products that potential customers might be searching for, and generally improve the visitors' experience on your website.<br/><br/><a href="https://piwik.org/docs/site-search/" rel="noreferrer" target="_blank">Learn more about Tracking how your visitors use your Search engine.</a>SearchesSearch Results pages @@ -2000,7 +2000,7 @@ ReferrersgetCampaignsCampaign - This report shows which campaigns led visitors to your website. <br /> For more information about tracking campaigns, read the <a href="http://piwik.org/docs/tracking-campaigns/" rel="noreferrer" target="_blank">campaigns documentation on piwik.org</a> + This report shows which campaigns led visitors to your website. <br /> For more information about tracking campaigns, read the <a href="https://piwik.org/docs/tracking-campaigns/" rel="noreferrer" target="_blank">campaigns documentation on piwik.org</a>VisitsUnique visitors ```

@sgiehl commented on October 15th 2017 Member

Did some more adjustments, but now everything should be fine.

This Pull Request was closed on October 15th 2017
Powered by GitHub Issue Mirror