@iMarkus opened this Pull Request on October 2nd 2017 Contributor

You can't access this resource as it requires an 'admin' access for the website id = 1. --> correct
You can't access this resource as it requires an 'view' access for the website id = 1. --> incorrect

Please issue pull request against the 3.x-dev branch only.

Piwik 2 is in LTS mode. This means we do not accept any pull request for 2.x except critical security bugs and major data loss bugs.

If you need to create a pull request for 2.x, then please also create the pull request against the 3.x-dev so we can merge both.

Happy hacking!

@mattab commented on October 2nd 2017 Owner

Thanks for the PR @iMarkus

LGTM :+1:

@sgiehl commented on October 2nd 2017 Member

This text occurs in various test files and needs to be updated there as well.

@sgiehl commented on October 8th 2017 Member

@iMarkus are you able to update the PR?

@iMarkus commented on October 9th 2017 Contributor

@sgiehl sorry, what do you mean with update?

@sgiehl commented on October 9th 2017 Member

Some of the tests contain the changed text. Those files needs to be updated
as well.

@iMarkus commented on October 9th 2017 Contributor

Done

@sgiehl commented on October 9th 2017 Member

@iMarkus seems you accidentally added line endings to those files. I've pushed a commit to your branch to remove them. Let's see if tests passes now

@iMarkus commented on October 9th 2017 Contributor

@sgiehl I did the edit in firefox browser and just deleted the 'an'. Wondering why line endings appeared.

@sgiehl commented on October 9th 2017 Member

Github seems to do that "automatically" in online editor. Wasn't able to remove them their either.

This Pull Request was closed on October 9th 2017
Powered by GitHub Issue Mirror