@ghimf opened this Issue on September 21st 2017

Since 3.1.0, the result/visitedPages/row elements, when the visited url contains the '=' character, instead of the expected:
<visitedPages><row key="http://example.org/homepage?param1=value1&param2=value2">1</row></visitedPages>
it returns:
<visitedPages><row http://example.org/homepage?param1="value1&param2=value2">1</row></visitedPages>

@mattab commented on September 21st 2017 Owner

Hi @ghimf

Thanks for the report. Can you please send the URL used to generate this API output?

Looking forward to fixing this issue

@ghimf commented on September 21st 2017

http://demo.piwik.org/?module=API&method=Live.getVisitorProfile&idSite=7&visitorId=VID&format=xml&token_auth=TAU
with valid VID and TAU values

@mattab commented on September 22nd 2017 Owner

@sgiehl re-opening because:

  • our automated tests do not show this actual bug. We need to have at least one test which shows the XML problem
  • to prevent the issue of invalid XML returned by API, we also need to add some test that ensures that all XML files are valid XML
@ghimf commented on October 12th 2017

Hello,

With the same URL as above
http://demo.piwik.org/?module=API&method=Live.getVisitorProfile&idSite=7&visitorId=VID&format=xml&token_auth=TAU
when the VID visitor used a "Portable media player" device, the result/devices element contains a not well-formed element named <Portable media player></Portable media player>.

Regards.

@mattab commented on October 13th 2017 Owner

thanks for letting us know @ghimf

@sgiehl commented on October 13th 2017 Member

Good point. I'll change that.

@mattab commented on October 16th 2017 Owner

Last remaining task AFAIK before closing issue:

  • to prevent the issue of invalid XML returned by API, we also need to add some test that ensures that all XML files are valid XML
Powered by GitHub Issue Mirror