@mneudert opened this Pull Request on August 7th 2017 Member

Currently every empty data table has full access to the controls. Like getting a CSV export or changing the rows displayed. But as there is no data to control they work but (at least to me) give the subtle impression there might be a setting to get some data displayed that was previously hidden.

As a change for that behaviour was rather simple I decided to go ahead with a PR to check if such a change is favorable.

For a nicer visual impression the whitespace should probably be modified to vertically center the message again instead of like right now just hide the footer:

http://builds-artifacts.piwik.org/mneudert/piwik/hide-empty-data-table-controls/97/EmptySite_emptySiteDashboard_ignored.png

(side-by-side displays the changes rather nice)

@sgiehl commented on August 7th 2017 Member

makes imho sense to hide the footer icons

@mattab commented on August 16th 2017 Owner

find it is a bit useful to have the controls even when there is no data. In some cases you want to get the "Export data URL" even when there is no data on that day (but you can change the day in the URL parameters afterwards).

  • Maybe we could hide the "Rows limit" control when there is actually no data?
@sgiehl commented on August 22nd 2017 Member

In some cases you want to get the "Export data URL" even when there is no data on that day (but you can change the day in the URL parameters afterwards).

Most users won't be able to do that for exports that automatically trigger a download (like csv, tsv,...). I would completely hide it until #11958 is finished and merged and maybe already includes date selection in the overlay

@mneudert commented on August 23rd 2017 Member

Updated the patch to only hide the limit control. This should be the least invasive modification without any potential harm. The broken screenshot tests seem unrelated.

If the new export overlay is coming in 3.1.0 it might be rather confusing if we hide all controls (including the generic visualization control) now only to show some of them again a version later.

We could always open a regular issue to discuss the various points of different implementations. Having a full date selector in an export overlay that is triggered by a widget saying "no data available" is at least to me nothing I would expect :D That said a complete export area to fulfill that role is probably not the most simple alternative and might confuse long time users.

This Pull Request was closed on September 14th 2017
Powered by GitHub Issue Mirror