@tsteur opened this Issue on August 4th 2017 Owner

In PHP 7.2 some new methods will be deprecated and trigger notices see https://devzone.zend.com/7628/deprecations-php-7-2/

I have noticed eg create_function() is being used and $php_errormsg. Didn't check all deprecated functions. Goal would be to update libs and code needed to not get any notices.

@mattab commented on September 18th 2017 Owner

See also this issue in Sparklines: #12065

@mattab commented on September 18th 2017 Owner
  • Probably we would need to enable the CI builds to run on PHP 7.2
@mneudert commented on September 18th 2017 Member

Just some thoughts on the CI

Would if be a possible solution to use a cron trigger for "non-minimum PHP versions" like 7.x?

Using a special repository containing only one branch for each PHP version with a custom .travis.yml could trigger specific builds without completely overloading Travis. Using a special repository avoids messing with branching on the main repository and should still reasonably ensure support of different PHP versions.

@mattab commented on September 18th 2017 Owner

It's a nice idea, but we found that it's easier to keep all the jobs into one build as otherwise it gets complicated and time consuming to follow all the builds.
Currently we run our builds on:

  • UI tests on PHP 5.5
  • all other tests on PHP 5.6 (both PDO MySql and Mysqli)

I reckon we only need to test the minimum version 5.5 and the maximum version ie. 7.2?
So maybe we could change to:

  • UI tests on PHP 5.5
  • Alltests suite (which runs Mysqli) on PHP 7.2
  • Unit/integration/system (which runs on PDO) on PHP 5.6

or

  • UI tests on PHP 5.5
  • Alltests suite (which runs Mysqli) on PHP 5.5
  • Unit/integration/system (which runs on PDO) on PHP 7.2
Powered by GitHub Issue Mirror