@patrickbr opened this Pull Request on July 24th 2017 Contributor

This PR adds e (see http://php.net/manual/en/function.date.php) to the Monolog date format. Since Piwik uses "UTC" as the default timezone, this will always add " UTC" to the end of the date string. Log lines will look like this:

WARNING Referrers[2017-07-24 18:04:14 UTC] Some message

This resolves problems with external tools reading the Piwik log. Previously, these tools assumed that the time was displayed in the system timezone. (See for example https://github.com/piwik/piwik/issues/2888#issuecomment-317319713 and https://github.com/piwik/piwik/issues/11888).

@mattab commented on July 24th 2017 Owner

Thanks for the PR!

in log file it is generally using the timezone abbreviation so let's use T instead of e as e would lead to long timezones like Pacific/Auckland whereas T shows NZST

@patrickbr commented on July 24th 2017 Contributor

You are right, I should've read a few more lines of the date format character list. I was not aware of T :)

This Pull Request was closed on July 25th 2017
Powered by GitHub Issue Mirror