@dudu84 opened this Pull Request on July 24th 2017 Contributor

Fix #11410

Please issue pull request against the 3.x-dev branch only.

Piwik 2 is in LTS mode. This means we do not accept any pull request for 2.x except critical security bugs and major data loss bugs.

If you need to create a pull request for 2.x, then please also create the pull request against the 3.x-dev so we can merge both.

Happy hacking!

@dudu84 commented on July 24th 2017 Contributor

@sgiehl I need help. My test is failing. The output states that a method I implemented (and defined in piwiktest.js) does not exists. I need a light on this.

@sgiehl commented on July 24th 2017 Member

You need to add the method names to the method listing in line 989

@dudu84 commented on July 24th 2017 Contributor

@sgiehl Thanks man! Now the tests are passing and the updated js is minified.

@dudu84 commented on July 26th 2017 Contributor

@sgiehl Hey Stefan! All good now?

@sgiehl commented on July 27th 2017 Member
@dudu84 commented on July 31st 2017 Contributor

@sgiehl done!

@sgiehl commented on August 1st 2017 Member

Looks good to merge for me now.
@mattab Shall we merge before releasing 3.0.5? Or wait for 3.1.0?

@mattab commented on August 2nd 2017 Owner
  • Please add the new function in the CHANGELOG.md file so the new method will appear in our developer changelog @ http://developer.piwik.org/changelog
  • Once done LGTM to merge for 3.0.5
@mattab commented on August 3rd 2017 Owner

Thanks @dudu84 for a great PR!

@dudu84 commented on August 3rd 2017 Contributor

@sgiehl and @mattab It's me who thank you guys for the patience and the opportunity to learn.

@mattab commented on December 13th 2017 Owner

Note: this feature wasn't working, but this PR hopefully fixes it: #12355

This Pull Request was closed on August 3rd 2017
Powered by GitHub Issue Mirror