Please issue pull request against the
3.x-dev branch only.
Piwik 2 is in LTS mode. This means we do not accept any pull request for 2.x except critical security bugs and major data loss bugs.
If you need to create a pull request for 2.x, then please also create the pull request against the
3.x-dev so we can merge both.
@sgiehl I need help. My test is failing. The output states that a method I implemented (and defined in piwiktest.js) does not exists. I need a light on this.
You need to add the method names to the method listing in line 989
@sgiehl Thanks man! Now the tests are passing and the updated js is minified.
Guess the method
setSecureCookie needs to be added in https://github.com/dudu84/piwik/blob/d3c57902a2fc463d97b7783d286731d63259cf0b/js/piwik.js#L7096
Looks good to merge for me now.
@mattab Shall we merge before releasing 3.0.5? Or wait for 3.1.0?
Note: this feature wasn't working, but this PR hopefully fixes it: #12355