@sgiehl there is also another query using this table,
$sql = "INSERT INTO $table (`idsite`, `plugin_name`, `setting_name`, `setting_value`) VALUES (?, ?, ?, ?)";
Could we apply the patch there as well?
We could add it. But actually while updating there shouldn't be any settings added before the table was created.
@mattab I wouldn't add the ignore to the inserts. Removing something that doesn't exist is imho no real "failure", but not adding something that should be added is a failure and should be reported as one.