@sgiehl opened this Pull Request on July 17th 2017 Member

fixes #11848

@mneudert commented on July 17th 2017 Member

Slow me missed that one :D

Screenshots look as expected I think. There is potentially a third case one if you enter a site with a value being int-casted 0 (at least I think that is what is going on there), like a literal zero or something non-numeric. Would that be relevant?

@sgiehl commented on July 17th 2017 Member

hm... shouldn't hurt to add a test for that as well

@sgiehl commented on July 17th 2017 Member

Actually setting a invalid site currently results in:
image

Imho we maybe shouldn't show such an error message to non super users. Most users might not even understand the error, so maybe we should simply redirect to index or similar. Will create a new issue for this, and won't add a test for it now

This Pull Request was closed on July 17th 2017
Powered by GitHub Issue Mirror