@dudu84 opened this Pull Request on June 30th 2017 Contributor

Please issue pull request against the 3.x-dev branch only.

Piwik 2 is in LTS mode. This means we do not accept any pull request for 2.x except critical security bugs and major data loss bugs.

If you need to create a pull request for 2.x, then please also create the pull request against the 3.x-dev so we can merge both.

Happy hacking!

@sgiehl commented on July 19th 2017 Member

Sorry, for the late reply.
There are still failing tests and the built js files needs a refresh.
@dudu84 are you able to handle this?

@dudu84 commented on July 20th 2017 Contributor

@sgiehl No problem. I can handle this on weekend. Is it ok?
By refresh the built js files you mean I need to update my repo and then build the files again?

@sgiehl commented on July 20th 2017 Member

By refresh the built js files you mean I need to update my repo and then build the files again?

Exactly. There have been other changes to piwik.js.

This Pull Request was closed on July 24th 2017
Powered by GitHub Issue Mirror