@sgiehl opened this Pull Request on May 23rd 2017 Member

Currently when clicking a download / export link for an report, the export_limit is used for limiting the records. As this value always defaults to [General] API_datatable_default_limit INI config option.
As that value isn't overwritten anywhere there was no possibility to change the limits for the export.

This change removes the export_limit option for data tables and uses the selected filter limit instead. That way the download will be limitted to the number selected for the datatable.

This is only kind of a quick fix. In the future we should maybe show a limit selection before starting the download instead of using the one for the datatable.

@tsteur commented on May 23rd 2017 Owner

haven't tested but looks good to me 👍

@mattab commented on June 21st 2017 Owner

This is only kind of a quick fix. In the future we should maybe show a limit selection before starting the download instead of using the one for the datatable.

I was looking for this issue as I thought we had one, but couldn't find it. I'll create one later as it'd be very useful to have a panel to configure the downloads

This Pull Request was closed on May 24th 2017
Powered by GitHub Issue Mirror