@Findus23 opened this issue on February 18th 2017

Follow-up to discussion in #11271

I have now modified the script so that instead of replacing white with transparency it floodfills all white parts with transparency beginning from all four corners. That way white parts of icons (e.g. Quicktime, Windows Media) will stay white and the icons look great on light grey backgrounds. While it improves many icons there are still some left, that are impossible to recognize on dark backgrounds (mostly because they are only made of dark lines) Because of that I would recommend adding a white background with CSS in these cases (mostly the black popup)

@mattab commented on February 20th 2017

I have now modified the script so that instead of replacing white with transparency it floodfills all white parts with transparency beginning from all four corners. That way white parts of icons (e.g. Quicktime, Windows Media) will stay white and the icons look great on light grey backgrounds.

This sounds ideal! Glad you could make this work.

Because of that I would recommend adding a white background with CSS in these cases (mostly the black popup)

:+1:

@Findus23 commented on February 20th 2017

I have now added a new release on https://github.com/Findus23/device-icons. Should I create a new pull request or wait until we have found a solution for Findus23/device-icons? (e.g. use as a composer package similar to piwik/searchengine-and-social-list)

@mattab commented on February 20th 2017

@Findus23 shall we create new issue regarding finding a solution to package icons in Piwik core via composer or submodule etc. ?

If we can find a solution quickly then maybe it's worth waiting to push the new icons to KISS

@Findus23 commented on February 20th 2017

@Findus23 shall we create new issue regarding finding a solution to package icons in Piwik core via composer or submodule etc. ?

see #11370

@Findus23 commented on April 7th 2017

This should have greatly improved with https://github.com/piwik/piwik-icons/commit/1161949e5ca23de8dbd1c261de03772fcc627436

This issue was closed on April 7th 2017
Powered by GitHub Issue Mirror