@robocoder opened this Issue on January 22nd 2010 Contributor

For consistency (and to avoid E_STRICT warnings), public API functions should be declared as "static public". In many cases, it's simply "public" (or in some cases, implied).

Use of $this should be replaced with self::getInstance().

@robocoder commented on January 30th 2010 Contributor

(In [1817]) fixes #1122

@robocoder commented on February 10th 2010 Contributor

(In [1832]) fixes #1122 - per Matt's review

@robocoder commented on February 10th 2010 Contributor

(In [1833]) refs #1122 - fix usage

@robocoder commented on February 10th 2010 Contributor

(In [1834]) refs #1122 - fix core usage

@robocoder commented on February 10th 2010 Contributor

(In [1835]) refs #1122 - fix unit test

@mattab commented on February 11th 2010 Owner

Tu summarize, instead of changing all API methods to being static, we decided to change all callers to not call methods statically as this could cause various issues in the future. Thanks vipsoft!

This Issue was closed on February 11th 2010
Powered by GitHub Issue Mirror