@stehlo opened this issue on December 17th 2016

An exception has been thrown during the rendering of a template (".form-description is undefined: failed at .form-description; line: 6621") in "@CoreUpdater/runUpdaterAndExit_welcome.twig" at line 8.

@Findus23 commented on December 18th 2016

Is it possible that this is the same issue as #10738? Do you use the InterSites plugin?

@stehlo commented on December 18th 2016

No, but among others I have use the following plugin from the other list: - TreemapVisualization

@tsteur commented on December 18th 2016

Can you go to Administration => Plugins. Then select the filter "Third-party" and let us know which ones are enabled?

It cannot really be triggered by TreemapVisualization but is likely a different plugin

@stehlo commented on December 18th 2016

Well, I would love to, but Piwik is not working due to this error.

@mattab commented on December 18th 2016

can you paste here the content of config.ini.php below the [Plugins] section?

Ideally we'd like to trigger our "safe mode" when this occurs, so that you can easily disable the plugin

@sgiehl commented on December 18th 2016

Maybe ClickHeat causes the problem. As far as I have seen that plugin is not yet compatible with Piwik 3

@tsteur commented on December 18th 2016

It seems to not override the topbar event, neither does WebsiteGroups. Probably one of the others

@tsteur commented on December 18th 2016

Actually InterSites is installed according to that list. Marking it as duplicate

@stehlo commented on December 18th 2016

Removing InterSites doesn't help at all. I don't even know what is that plugin.

@sgiehl commented on December 18th 2016

Did you also remove that plugin from filesystem?

@stehlo commented on December 18th 2016

No, just disabled it via config file. Is it not a core plugin?

@stehlo commented on December 18th 2016

I have moved it within the file system, and the upgrade proceeds now. Is this plugin critical for the operation of Piwik?

@sgiehl commented on December 18th 2016

No it isn't (See http://plugins.piwik.org/InterSites). Try removing it from file system.

@stehlo commented on December 18th 2016

OK, thanks. I am glad, this wasn't a production system...

@stehlo commented on December 18th 2016

By the way, the version 3.0 looks very good (speedwise, etc.).

@stehlo commented on December 18th 2016

Although the change of time period doesn't work. :-( That's a regression. And not even in my favourite Pale Moon, but in Google Chrome!

@stehlo commented on December 18th 2016

OK, so it looks like this version 3.0 has still a long way to go.

Is there an easy way to downgrade back to the latest version 2?

@mattab commented on December 18th 2016

Piwik 3 is ready and will be released today.

Changing time periods works for us. See it: http://demo.piwik.org/

@mattab commented on December 18th 2016

there is no easy way to downgrade to 2.x

@stehlo commented on December 18th 2016

Interesting, indeed. My Piwik is nearly empty, yet it doesn't work in that way. I wonder whether some plugins still don't need updating. Will come back shortly.

@stehlo commented on December 18th 2016

Maybe after all the insufficiency of data could be the reason...?

@mattab commented on December 18th 2016

@stehlo * go to Settings > Plugins and update all plugins that can be updated * go to Marketplace > Third party. Which third party plugins are listed here? * Disable one by one the third party plugins (not those created by "piwik" since they should work), until you find that the JS error is gone

Which plugin was causing the JS error?

@stehlo commented on December 18th 2016

I don't see any updateable plugins.

Which plugin was causing the JS error?

No idea. Maybe it doesn't relate to any plugin.

@sgiehl commented on December 18th 2016

You might also try to clean the tmp directory of Piwik.

@mattab commented on December 18th 2016

Go to Marketplace > Third party. Which third party plugins are listed here?

Then, you can try to disable these plugins one by one, until you find that your Piwik date range/calendar is working well again as expected

@stehlo commented on December 18th 2016

By the way, just for your information, those errors do NOT relate to the changes of time periods.

They are just general errors happening when loading dashboard widgets.

@stehlo commented on December 18th 2016

OK, all plugins tested (disabled and re-enabled). The only non-Piwik-produced plugin was "Bot Tracker".

This means that all the errors and time-period-change issue are not related to plugins.

@stehlo commented on December 18th 2016

Now I am absolutely positive that the following error prohibits further operation of XHR responses:

Uncaught TypeError: this.jsViewDataTable.indexOf is not a function at DataTable.setFixWidthToMakeEllipsisWork (index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1166) at DataTable.bindEventsAndApplyStyle (index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1142) at DataTable.init (index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1128) at new DataTable (index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1126) at HTMLDivElement. (index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1127) at Function.each (index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4) at n.fn.init.each (index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4) at Function.DataTable.initNewDataTables (index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1127) at HTMLDocument.eval (eval at globalEval (index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4), :2:39) at i (index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4) setFixWidthToMakeEllipsisWork @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1166 bindEventsAndApplyStyle @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1142 init @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1128 DataTable @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1126 (anonymous) @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1127 each @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 each @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 DataTable.initNewDataTables @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1127 (anonymous) @ VM2877:2 i @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 add @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 n.fn.ready @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 (anonymous) @ VM2877:1 globalEval @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 ua @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:5 append @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:5 (anonymous) @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:5 K @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 html @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:5 t.fn.html @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:31 onWidgetLoadedReplaceElementWithContent @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:3022 success @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1004 i @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 fireWith @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 z @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:6 (anonymous) @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:6

@stehlo commented on December 18th 2016

I wonder whether the following is also not an issue:

Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.

send @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:6 ajax @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:6 _buildAjaxCall @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1006 send @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:999 widgetsHelper.getAvailableWidgets @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:2721 construct @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:2750 DashboardSettingsControlBase @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:3053 DashboardManagerControl @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:3053 (anonymous) @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1026 each @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 each @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 UIControl.initElements @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:1026 DashboardManagerControl.initElements @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:3053 (anonymous) @ index.php?module=CoreHome&action=index&idSite=20&period=day&date=today:619 i @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 fireWith @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 ready @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4 J @ index.php?module=Proxy&action=getCoreJs&cb=3fb6f03…:4

@sgiehl commented on December 18th 2016

You might add the following to your config.ini.php:

[Development]
enabled = 1
disable_merged_assets = 1

This enables development mode and disables the merged assets. That way all javascript files will be loaded separately. That should help to exactly trace down where the error occurs.

@stehlo commented on December 18th 2016

Oops! When I see AngularJS, I am already worried about the code...

@stehlo commented on December 18th 2016

Anyway, I should mention that the problems I am describing (including the time-period-change) relate ONLY to the custom dashboard.

@mattab commented on December 18th 2016

@stehlo can you please try to apply this patch: https://github.com/piwik/piwik/commit/0e3cf3254aa3bd202e478400aed0d4b5a4343f5a

and then delete your piwik/tmp/ folder and try again?

@stehlo commented on December 18th 2016

I just wanted to recommend something like that, because the debugging has shown that jsViewDataTable is sometimes equal to "graphEvolution", sometimes to "table", but sometimes it is not set at all.

@stehlo commented on December 18th 2016

Excellent!

I have tested with other dashboard widgets and everything works fine.

Thank you, Matthieu.

The donation for the fix has been just wired to your Paypal account.

@mattab commented on December 18th 2016

Thanks @stehlo for the quick feedback! it's good to know we caught this issue just before release :+1:

@stehlo commented on December 18th 2016

Yes, it would have been a nasty surprise for many people.

Surprisingly, one liners can be show-stoppers sometimes... ;-)

@mattab commented on December 18th 2016

as we'd like to find the root cause, do you know in which widget this error appeared? how could we reproduce this error? do you find a way now to reproduce it on demo.piwik.org (still running rc4) ?

@stehlo commented on December 18th 2016

I had only 5 widgets in the following order at that time:

Column 1 - Visits Over Time - Operating System versions - Browsers

Column 2 - Visitors in Real-time

Column 3 - Country

The error happened regardless of the type of Measurables (Website or Mobile App).

@mattab commented on December 19th 2016

fixed in #11035

This issue was closed on December 19th 2016
Powered by GitHub Issue Mirror