Looks good, but when do we need to use %% VS simply %? noticed there are more
% used in translations (in Insights plugin, CustomAlerts, Intl, AbTesting).
Should we change them all maybe? to find them all I did a regex search in phpstorm
%[^sd1-9] restricted to file masks en.json
Also maybe we could add an integration test that fails when a % sign isn't escaped in english translation?
There are already quite a few
% escaped in some translations. That already works fine when there are other placeholders being used.
The only reason for escaping all
% symbols in translations is to get them translatable in transifex. Transifex won't accept translations if the number of placeholder is changed. As it sometime recognizes
% d as placeholder, even if there is a space between, it's impossible to add a translations.
%% should work without problems on Transifex.
I'll check and add a little test for that.
Added a little test. Might maybe fail because of some translations in CustomAlerts plugin, but I would fix those, after this PR was merged
LGTM, +1 to merge & fix tests