@mattab opened this Issue on November 15th 2016 Owner

See discussion in: https://github.com/piwik/piwik/pull/10842

The UI test Overlay_page_new_links / page_new_links does not work about since this PR was merged #10580

See for example at: http://builds-artifacts.piwik.org/piwik/piwik/new_submoduels/20945/Overlay_page_new_links.png

diff

@sgiehl commented on December 30th 2016 Member

Seems this one is already fixed somehow... latest process screenshot looks correct http://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/21730/processed/Overlay_page_new_links.png

@mattab commented on December 30th 2016 Owner

But the expected one doesn't: https://github.com/piwik/piwik/blob/3.x-dev/tests/UI/expected-screenshots/Overlay_page_new_links.png

do you know why tests are passing anyway?

@sgiehl commented on December 30th 2016 Member

Test was changed to check for "similar" image. I'll remove that...

This Issue was closed on December 30th 2016
Powered by GitHub Issue Mirror