I've updated the expected screenshots where I think the changes are valid. One is still failing due to some changes merged in https://github.com/piwik/piwik/pull/10580 Tried to figure out for a while why it is failing, but I didn't success. Reverting the changes from #10580 fixed the test again, so it needs to be one of the change there...
@mattab @tsteur could anyone have a small look at the changes and merge the PR if all are valid?
Looks all good to me. The screenshot you mentioned not sure why it fails. It may be a random screenshot failure. Maybe we wait for a bit to see if it occurs all the time?
Tried that more than once. It's definitely not random. Fails always, but succeeds if changes of the mentioned PR are reverted.
Maybe https://github.com/piwik/piwik/compare/3.x-dev...overlay_uitest_fix?quick_pull=1 helps. Otherwise we might need to improve the selector and then it may work
I'll merge this one now. We can try to fix the remaining test later
FYI: I tried a few more times to fix the other test in https://github.com/piwik/piwik/compare/3.x-dev...overlay_uitest_fix?quick_pull=1 but it gets a wrong x/y coordinate see https://travis-ci.org/piwik/piwik/jobs/174025516#L1079 We will need to execute that test locally and then open the test URL (possible when running tests with