@sgiehl opened this Pull Request on November 6th 2016 Member

I've updated the expected screenshots where I think the changes are valid.
One is still failing due to some changes merged in https://github.com/piwik/piwik/pull/10580
Tried to figure out for a while why it is failing, but I didn't success. Reverting the changes from #10580 fixed the test again, so it needs to be one of the change there...

@mattab @tsteur could anyone have a small look at the changes and merge the PR if all are valid?

@tsteur commented on November 7th 2016 Owner

Looks all good to me. The screenshot you mentioned not sure why it fails. It may be a random screenshot failure. Maybe we wait for a bit to see if it occurs all the time?

@sgiehl commented on November 7th 2016 Member

Tried that more than once. It's definitely not random. Fails always, but succeeds if changes of the mentioned PR are reverted.

@tsteur commented on November 7th 2016 Owner

Maybe https://github.com/piwik/piwik/compare/3.x-dev...overlay_uitest_fix?quick_pull=1 helps. Otherwise we might need to improve the selector and then it may work

@sgiehl commented on November 7th 2016 Member

I'll merge this one now. We can try to fix the remaining test later

@tsteur commented on November 7th 2016 Owner

FYI: I tried a few more times to fix the other test in https://github.com/piwik/piwik/compare/3.x-dev...overlay_uitest_fix?quick_pull=1 but it gets a wrong x/y coordinate see https://travis-ci.org/piwik/piwik/jobs/174025516#L1079 We will need to execute that test locally and then open the test URL (possible when running tests with --keep-symlinks --persist-fixture-data)

This Pull Request was closed on November 7th 2016
Powered by GitHub Issue Mirror