@mattab opened this Issue on November 3rd 2016 Owner

from https://github.com/piwik/piwik/pull/10815

Reasoning behind requesting a partial revert:

  • cannot remember why we marked we would remove those calls
  • Removing them would cause some errors in the way users may embed these reports in their app, forcing them to change apps or products or apps, which is time consuming for them
  • there is no advantage for the platform to remove this code: this is very little code with no complexity and most is tested...
@sgiehl commented on November 3rd 2016 Member

Imho there is not much value in keeping that forever and it would be accaptable if some user may need to change the emedded urls. The plugin was deprecated in 2.10.0 over a year ago.
If we remove them, we should do it with a major release and I wouldn't wait for 4.0.

@mattab commented on November 14th 2016 Owner

@sgiehl +1 to remove them but then could we note again in the developer changelog the methods removed and the new methods to use instead.

@sgiehl commented on November 14th 2016 Member

I'd add something like:

Widgets using the already removed UserSettings plugin won't work any longer. Please recreate your widget urls using DevicesDetection, Resolution or DevicePlugins plugin instead.

But should we really list all methods that had been removed a long time ago?

@mattab commented on November 15th 2016 Owner

But should we really list all methods that had been removed a long time ago?

Yes let's list them all, as the Widget URL embed API was effectively broken it's important I feel to lay out changes we made. Ideally we'd just have to "Copy paste" the previous changelog entries where we would announce the 'url rewrites', but seems we didn't document it so far, so it will be the first time we document.

This Issue was closed on November 15th 2016
Powered by GitHub Issue Mirror