@anonymous-piwik-user opened this Issue on November 2nd 2009

in misc/cron/archive.sh line 26:

PIWIK_CRON_FOLDER=dirname $(readlink -f ${0})

Gives an error:
readlink: illegal option -- f
usage: readlink [file ...
usage: dirname string

Testing readlink on Scientific Linux SL release 5.3

readlink -f /path/to/file

also gives an error

readlink: Need exactly one argument.
Try `readlink --help' for more information.

@anonymous-piwik-user commented on November 2nd 2009

Attachment:
archive.sh

@anonymous-piwik-user commented on November 2nd 2009

Attachment:
archive.patch

@robocoder commented on November 2nd 2009 Contributor

Remove the -f and report back to us.

@anonymous-piwik-user commented on November 2nd 2009

man readlink says:
'When invoked as readlink, only the target of the symbolic link is
printed. If the given argument is not a symbolic link, readlink will
print nothing and exit with an error.'

I've changed it to
PIWIK_CRON_FOLDER=dirname ${0}

To make my local version work

@robocoder commented on November 2nd 2009 Contributor

Ah yes, thanks for the reminder. That's why we use -f.

@anonymous-piwik-user commented on November 2nd 2009

act_path() {
    local pathname="$1"
    readlink -f "$pathname" 2>/dev/null || \
    realpath "$pathname" 2>/dev/null || \
    type -P "$pathname" 2>/dev/null
}

ARCHIVE=`act_path ${0}`
PIWIK_CRON_FOLDER=`dirname ${ARCHIVE}`

The above works for me on FreeBSD and Scientific Linux SL

@mattab commented on November 2nd 2009 Owner

ogs22, do you think you could submit a version that works on freebsd-SL linux and on debian/other linux? it would be very useful. Thanks

@anonymous-piwik-user commented on November 2nd 2009

Sorry yes I should have said the above code should work on any Linux version the original code worked on as it tries the readlink -f first.

I'll attach the modified archive.sh

@mattab commented on November 2nd 2009 Owner

ogs22, could you post a diff instead of the full file please? thx

@robocoder commented on November 5th 2009 Contributor

In [1568], fixes #1033 - archive.sh patch; thanks ogs22

This Issue was closed on November 5th 2009
Powered by GitHub Issue Mirror