@tsteur opened this Issue on July 12th 2016 Owner

See https://travis-ci.org/piwik/piwik/jobs/144259287

eg

22) Piwik\Plugins\Test\Columns\UpdaterTest::test_getMigrationQueries_ReturnsCorrectQueries_IfDimensionIsNotInTable
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

we should probably update this soon

@sgiehl commented on July 17th 2016 Member

I don't think we should fix that in LTS. getMock was deprecated in PHPUnit 5.4.0. That version of PHPUnit already requires PHP >= 5.6
As the LTS should still support PHP 5.3 we can't use one of the latest PHPUnit versions using composer

@tsteur commented on July 17th 2016 Owner

👍 moving it to 3.x

@tsteur commented on August 1st 2016 Owner

I have updated them in a Piwik 3 branch. will be merged later.

@mattab commented on August 22nd 2016 Owner

just realised that Travis does not use the PHPUnit version that we set in our composer.json but it uses the latest PHPUnit offered by travis. The integration tests are failing now, (see https://travis-ci.org/piwik/piwik/jobs/154281157) - PHPUnit must have broken BC for getMock...

Can think of two ways to solve issue:

  • we backport the tests fixes in LTS as well,
  • or we could set Travis to use our composer.locked PHPUnit version
@tsteur commented on August 22nd 2016 Owner

or we could set Travis to use our composer.locked PHPUnit version

sounds better

@mattab commented on August 22nd 2016 Owner

@tsteur sounds good, done in master

This Issue was closed on September 13th 2016
Powered by GitHub Issue Mirror