@blueelvis opened this issue on July 9th 2016

Regarding - #10167

Does this look good?

@blueelvis commented on July 9th 2016

@mattab - Really sorry that I mistakenly committed code from 2 different issues. So, this pull request now also contains fix for the issue #10164

@auchri commented on July 9th 2016

Recommended should be translated into the other languages.

@blueelvis commented on July 9th 2016

@auchri - Ok thanks! I will fix it. Is this why the test failed?

@auchri commented on July 9th 2016

No, PhontomJS crashed during the build.

@tsteur commented on July 10th 2016

I think the PhantomJs crash is not related to your change. I will restart the test

@blueelvis commented on July 11th 2016

@tsteur @auchri - I have updated the code. Please let me know if there is anything else which needs to be changed :)

@blueelvis commented on July 11th 2016

The test is still failing because of pixel difference. Can it be caused because of the fact that I have added the (Recommended) word?

@tsteur commented on July 11th 2016

You can see the UI changes / the failing tests here: http://builds-artifacts.piwik.org/piwik/piwik/master/19281/ and they look good. We will fix them once this PR is merged

@tsteur commented on July 11th 2016

Can someone confirm the PR works as expected? I presume we might need to test this in different browsers.

@mattab commented on July 11th 2016

Thanks @blueelvis for the PR. did you maybe test the iframe code in several browsers such as IE and Firefox? according to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options it won't work on Chrome anyway..

@blueelvis commented on July 15th 2016

Please close this PR because for some unknown reason, this is not getting updated. New PR has been created #10317

This issue was closed on July 16th 2016
Powered by GitHub Issue Mirror