@adaqus opened this Pull Request on June 23rd 2016

Currently when plugin cannot be loaded warning message looks as below:

old_warning

This information is misleading, because it appears also when plugin's directory is empty or is not readable. This PR introduces following message:

new_warning

@mattab commented on July 8th 2016 Owner

It would be even better to check all these things and then directly point it out. Eg we could check whether a plugin is not compatible, we could check if directory does not exist and mention it, and we could check if directory exists but is empty (or misses a plugin.json)

:+1: to write the actual cause of the error, so it is most helpful for troubleshooting without effort needed on the user's part.

@adaqus commented on July 20th 2016

@mattab This is a good idea and it is even worth to enhance it: set of plugin validators can be created that would be reusable in many places in Piwik, for example also in plugin:activate command, where information about problems with plugin would be very helpful.

But so far we have no resources to implement feature where for each plugin actual cause of problem is displayed. Change introduced with this PR is still some improvement which may significantly decrease time spent on investigating why plugin cannot be activated.

@mattab commented on September 23rd 2016 Owner

@adaqus Sounds like maybe you would not apply the feedback to the PR. I'm closing for now but feel free to re-open with the feedback applied and we'll be happy to merge :+1:

This Pull Request was closed on September 23rd 2016
Powered by GitHub Issue Mirror