@joubertredrat opened this Pull Request on June 22nd 2016 Contributor

This is small change, but is necessary for https://github.com/piwik/piwik/issues/9975, https://github.com/piwik/piwik/issues/4920 and others. On my tests, even with single quote, numeric idSite works fine for simple pageview track.

@tsteur commented on June 29th 2016 Owner

Looks good to me. There shouldn't be any security risks from what I can see as we always check the site exists etc. Any thoughts @mattab or @sgiehl ?

@sgiehl commented on June 29th 2016 Member

No concerns from my side

@tsteur commented on June 30th 2016 Owner

Thanks for the pull request @joubertredrat and looking forward to see the plugin on the Marketplace 👍

This Pull Request was closed on June 30th 2016
Powered by GitHub Issue Mirror