@mattab opened this Issue on May 23rd 2016 Owner

This improvement was reported and suggested by Abhishek Abhishek:

Proof of Concept

Suppose, you have an account on Piwik

Somehow an attacker manage to get your password and logged in your account.. after knowing that your ID has been compromised what you'll do ?
i guess first thing that will popup into your head is, "I should change my password!" and you'll change the password.. maximum users just change his/her password when they recover their ID.
in Piwik, changing the password doesn't destroys the other sessions which are logged in with old passwords.
(Logging in with the new password doesn't invalidate the older sessions either)
As other sessions is not destroyed, attacker will be still logged in your account even after changing password, cause his session is still active.. he'll have complete access on your account till that session expires!
So, your account remains insecure even after the changing of password.

Solution

When someone change his/her password, each and every active sessions that belongs to that particular account must be destroyed!

I would recommend you to follow Facebook on this security issue.. They fixed this issue few months back by adding a process that asks users whether user want to close all open sessions or not right after changing password.

So there is two way, either you let users to choose if they want to keep active sessions or just destroy every active sessions when users change his/her password!

Related issues

  • Ability to log out all currently logged in sessions is covered in #6126 : List all sessions I'm currently signed in Piwik and let me signout
  • #6531: When logging out, for improved security, maybe we should also destroy other user sessions
@mattab commented on August 24th 2017 Owner
This Issue was closed on August 24th 2017
Powered by GitHub Issue Mirror